Fix Cookie::stricmp to safely lowercase signed chars#2502
Open
Kushan20070126 wants to merge 1 commit intodrogonframework:masterfrom
Open
Fix Cookie::stricmp to safely lowercase signed chars#2502Kushan20070126 wants to merge 1 commit intodrogonframework:masterfrom
Kushan20070126 wants to merge 1 commit intodrogonframework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix undefined behavior in cookie SameSite case-insensitive comparison.
Cookie::stricmpusedtolower(str1[idx])directly onchar.When
charis signed and contains non-ASCII byte values, callingtolowerthis way is undefined behavior.Cast each character to
unsigned charbefore passing it tostd::tolower, then cast back tocharfor comparison.This makes SameSite string comparison standards-compliant and safe across platforms/char signedness, with no behavior change for normal ASCII inputs.
unittesttarget../build/lib/tests/unittest -r CookieTest -s